Rewrite findTargets for better performance. #11754
Merged
+17
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Avoids O(n^2) destroyer checks. - Avoids an expensive removeAll() call. - Uses a single stream filter to process, removing an unnecessary intermediate collection in the common case when no destroyers are present. Note: This was showing up in performance profiles.
DanVanAtta
reviewed
Jul 12, 2023
| .collect(Collectors.toSet()); | ||
| UnitType unitType, boolean destroyerPresent, Set<UnitType> enemyUnitTypes) { | ||
| Set<UnitType> cannotTarget = unitType.getUnitAttachment().getCanNotTarget(); | ||
| // Note: uses a single stream instead of a sequence of removeAll() calls for performance. |
There was a problem hiding this comment.
This comment will be confusing to those not looking at this diff! =D
(Arguably this is something for the commit history)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary & Additional Notes
Note: This was showing up in performance profiles.
Release Note